Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Consistent labelling #1793

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: Consistent labelling #1793

wants to merge 8 commits into from

Conversation

a-thaler
Copy link
Collaborator

Description

Changes proposed in this pull request (what was done and why):

  • Introduced consistent labelling across all resources
  • All resources via kustomize and the manager are adjusted
  • selectors are kept stable to avoid unneccessary investements
  • mainly removed labels as I dont see a value
    • control-plane: telemetry-manager
    • app.kubernetes.io/component: telemetry
    • app.kubernetes.io/managed-by: kustomize
  • added label
    • kyma-project.io/module: telemetry
  • changed value
    • app.kubernetes.io/part-of: telemetry

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@a-thaler a-thaler added kind/feature Categorizes issue or PR as related to a new feature. area/manager Manager or module changes labels Jan 29, 2025
@a-thaler a-thaler added this to the 1.33.0 milestone Jan 29, 2025
@a-thaler a-thaler requested a review from a team as a code owner January 29, 2025 17:03
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 29, 2025
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 29, 2025
@a-thaler a-thaler changed the title Labels feat: Consistent labelling Jan 29, 2025
@k15r
Copy link
Contributor

k15r commented Jan 31, 2025

mainly removed labels as I dont see a value
control-plane: telemetry-manager
app.kubernetes.io/component: telemetry
app.kubernetes.io/managed-by: kustomize

app.kubernetes.io/component is mentioned here. it might make sense (even though it is similar to kyma-project.io/module: telemetry) to keep it.

k15r
k15r reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@k15r k15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR makes the components more consistent in context of the telemetry-module, but in context of a bigger k8s setup it breaks consistency by only partially applying recommendations.

@a-thaler
Copy link
Collaborator Author

a-thaler commented Feb 3, 2025

We agreed on:
app.kubernetes.io/component: controller | agent | gateway | monitor # dependent on the component type
app.kubernetes.io/managed-by: kyma / telemetry-manager # dependent on if it was deployed by kustomize or by the manager

@skhalash skhalash modified the milestones: 1.33.0, 1.34.0 Feb 4, 2025
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 4, 2025
@a-thaler a-thaler enabled auto-merge (squash) February 4, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k15r k15r k15r left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@k15r k15r

Labels
area/manager Manager or module changes cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
1.34.0
Development

Successfully merging this pull request may close these issues.
4 participants
@a-thaler @k15r @skhalash @kyma-bot